Repository navigation
fix: preserve canonical metadata after Notion hydration - #195
Closed
Vamsi-2581 wants to merge 4 commits into
Closed
Vamsi-2581 wants to merge 4 commits into
Vamsi-2581 wants to merge 4 commits into
Conversation
Collaborator
|
Thanks for working on #193 and for the detailed test. We can't merge this one, for two reasons:
Running the generated client script in Closing this as superseded by #194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated Notion client overwrites the canonical link and social URL metadata after the Worker sets them. This can leave canonical URLs pointing at a Notion-generated path and make og:url relative.
The generated client now derives the canonical URL from the current route using the Worknot rules for the home page, mapped slugs, unmapped page IDs, and custom 404 pages. It reapplies the canonical link, og:url, and twitter:url after head mutations and history navigation.
The regression test executes the generated client script with a lightweight DOM stub and covers Notion metadata rewrites plus mapped and unmapped client-side navigation.
Fixes #193
Validation
AI assistance
Prepared with OpenAI Codex assistance.